feat(ui): inline diff in chat#2934
Merged
Merged
Conversation
Deploying codecompanion with
|
| Latest commit: |
cbb0235
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://69d47c28.codecompanion.pages.dev |
| Branch Preview URL: | https://feat-better-diffing.codecompanion.pages.dev |
Owner
Author
|
@iamthebot FYI |
|
Howdy, this is a neat feature. I just noticed what seems like a bug though, should 
|
Owner
Author
|
@Or1g3n - Good spot! I'll push a fix tonight |
Not sure if its a bug, it just seems if you press any of the keys while in chat, there's no confirmation afterwards. |
Owner
Author
|
I didn't deliberately add a confirmation as the LLM should respond. But marking the choice in some way does feel like a sensible idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables a diff to be shown in the chat buffer. It's configurable via
display.diff.threshold_for_chatwhich reflects the number of additions and deletions in a given diff, and by default is set to6(number derived from my testing on my laptop).The current workflow for a diff in a chat buffer:
threshold_for_chat, display the diff inlinethreshold_for_chatand the chat buffer is active, open the diff in a floating windowthreshold_for_chatbut the user is not in the chat buffer, display a notification. The user then needs to dogvin the chat buffer to view it.AI Usage
Opus 4.6
Related Issue(s)
Builds on #2917.
Screenshots
Checklist
make allto ensure docs are generated, tests pass and StyLua has formatted the code